Placeholder: Fix hover style. #44701
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +39 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Oct 10, 2022
|
@jasmussen should this be backported along with #44150? |
jasmussen
force-pushed
the
fix/placeholder-hover
branch
from
a935a43 to
6e3bc57
Compare
|
I can't get the tests to pass. They appear to be timing out. I'll restart one last time. If they pass, feel free to merge, this css only fix should be perfectly safe. Otherwise I'll try again tomorrow. |
jasmussen
force-pushed
the
fix/placeholder-hover
branch
from
6e3bc57 to
867536b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #44150 which moved a hover style from a pseudo element onto the block itself. This caused an issue where the backdrop-filter applied to placeholders got blurred:
This PR moves it back to a pseudo element, fixing the issue:
The PR also includes a fix for an occasional Chrome/Mac glitch where the backdrop filter placeholder would lose its color on resizing.
Testing Instructions
Test image placeholders in various contexts, including inside a Cover block that has a background. The new placeholder style should work well in all contexts.